----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ -----------------------------------------------------------
(Updated July 30, 2013, 8:46 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes ------- Moved the functionality of adding and remove vlan to addOrRemoveVlan function. This is called by both create and update physicalnetwork methods. As a result both create and update physical network can handle multiple vlan ranges. now we can reset the valan ranges to a null value. Added a comment to clarify the usage of the deletevnets function. Bugs: Cloudstack-3753 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) ----- api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing ------- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
