vishesh92 commented on PR #109: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/109#issuecomment-6161652903
> Hi @vishesh92 , @DaanHoogland , I reviewed the changes for per-Service Network ACL ownership. The ownership and cleanup approach looks worth testing carefully, particularly when multiple Services share a port. One additional improvement is to use `%w` when wrapping underlying errors so callers can inspect the original errors. I also noticed the E2E helper `requireNoACLRules` checks only exact start/end port matches, so it may miss a leftover rule whose port range includes the requested port. The existing Copilot comment flags this as well. Thanks for the review. we need to ensure that deleting a service doesn't delete a rule which is used by another service. So, each service will have it's own rule. We don't really care about the range conflicts for these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
