----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24299 -----------------------------------------------------------
Ship it! Ship It! - edison su On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13088/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 10:18 p.m.) > > > Review request for cloudstack, edison su and Wido den Hollander. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959 > > > Repository: cloudstack-git > > > Description > ------- > > CloudStack failed to add kvm host when 'pXpY' name format (udev named) > physical interface is a member of the bridge (kvm traffic label) on the host. > > Root cause is in > com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String). > There're no handling code for 'pXpY' format interface, so I added that. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 571bcc8 > > Diff: https://reviews.apache.org/r/13088/diff/ > > > Testing > ------- > > Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu > 13.04). > > > Thanks, > > Toshiaki Hatano > >