> On July 30, 2013, 3:43 p.m., Jenkins Cloudstack.org wrote: > > Review 13063 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #85 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/85/
Please note jenkins attempted to apply this to the master branch and not the ldapplugin branch resulting in a fail. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13063/#review24241 ----------------------------------------------------------- On July 30, 2013, 3:20 p.m., Ian Duffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13063/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 3:20 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Repository: cloudstack-git > > > Description > ------- > > Disables password changing from the API when LDAP is enabled. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/LdapValidator.java PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java > 60d1a97 > api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java > 52ec2ab > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java > b6fb3e8 > > Diff: https://reviews.apache.org/r/13063/diff/ > > > Testing > ------- > > Compiled... unit tests passed. > > Enabled LDAP... attempted to change password, failed as expected. > Disabled LDAP... attempted to change password, success as expected. > > > Thanks, > > Ian Duffy > >