----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review24559 -----------------------------------------------------------
The fix is good, but the patch failed to apply: alena@macbookpro: [4.2]~/cloudstack-oss$ git am ~/Desktop/db_remove_206_row.patch.2 --whitespace=nowarn Applying: Removing duplicate unreferenced row error: patch failed: setup/db/db/schema-410to420.sql:276 error: setup/db/db/schema-410to420.sql: patch does not apply Patch failed at 0001 Removing duplicate unreferenced row The copy of the patch that failed is found in: /Users/alena/cloudstack-oss/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". - Alena Prokharchyk On July 27, 2013, 7:22 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12976/ > ----------------------------------------------------------- > > (Updated July 27, 2013, 7:22 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra > Bhamidipati. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647 > > > Repository: cloudstack-git > > > Description > ------- > > Remove duplicate row (id=206) from table guest_os. > Decided to remove instead of checking for duplicates on insertion since : > 1. The new row is referenced by id=166 elsewhere in the DB > 2. Old row with id=206 is not referenced in DB > > > Diffs > ----- > > setup/db/db/schema-410to420.sql 82ca403 > setup/db/db/schema-410to420.sql 82ca403 > > Diff: https://reviews.apache.org/r/12976/diff/ > > > Testing > ------- > > Local environment > > > Thanks, > > Amogh Vasekar > >
