----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24576 -----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/13240/#comment48591> Don't remove it... It's a bug here. It should be if ((networkId == null && vpcId == null) || (networkId != null && vpcId != null)) { || rather than && - Sheng Yang On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13240/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 1:15 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > dealt with some warnings in NetworkServiceImpl > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 > > Diff: https://reviews.apache.org/r/13240/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
