----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13237/ -----------------------------------------------------------
(Updated Aug. 6, 2013, 7:13 p.m.) Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh. Changes ------- Incorporated comments rebased with latest 4.2 and tested the patch. Bugs: 3781 Repository: cloudstack-git Description ------- Issue: ====== for Volume operations we are finding the hypervisor type. Volume can be in ZONE/Cluster scope storage pool. when volume is in ZONE scope, there is issue with they way we fetch the hypervisor type. It was written to handle Cluster scope only. fixed: ====== Fixed with sql queries to fetch the Hypervisor type. 1. Fetch the hypervisor type for volume from storage pool table if the voluem is in ZONE scope storage pool. 2. Fetch the hypervisor type for volume from cluster table if the voluem is in CLUSTER scope storage pool. Diffs (updated) ----- engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 Diff: https://reviews.apache.org/r/13237/diff/ Testing ------- Setup: KVM and Xenserver with Adv Zone. Added pool Zone scope on KVM and Cluster Scope on Xenserver 1. created instances on KVM and xenserver. 2. Create two volumes attached to instances on KVM and Xenserver. 3. vol1 is in Zone scope and vol2 is in cluster scope. 4. Successfully performed resize opertions on vol1 and vol2. 5. Succssfully attached/detaches volumes Thanks, Rajesh Battala