> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 79 > > <https://reviews.apache.org/r/12849/diff/5/?file=337785#file337785line79> > > > > I don't quite understand this part. Why "//" is missing in this case? > > Who would require "//" and who wouldn't? > > daan Hoogland wrote: > Only the mido code needs the explicit // the rest can deal with URI > constructors
Are you sure? I'm seeing problems with CitrixResourceBase.getNetwork(CitrixResourceBase.java:1043): long vlan = Long.parseLong(broadcastUri.getHost()); - Donal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24756 ----------------------------------------------------------- On Aug. 7, 2013, 9:40 a.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 9:40 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for > backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > api/test/com/cloud/network/NetworksTest.java 31114e8 > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
