----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13495/#review24999 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On Aug. 12, 2013, 12:28 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13495/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 12:28 p.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: CLOUDSTACK-4189 > > > Repository: cloudstack-git > > > Description > ------- > > Listing out dedicated zones with zone id is returning all dedicated zones. > Issue: search criteria was always passing null for the zoneid. > Fixed the issue by setting zoneId inplace of datacenter id. > > > Diffs > ----- > > server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java 6c91ce7 > > Diff: https://reviews.apache.org/r/13495/diff/ > > > Testing > ------- > > list dedicatedzone with zoneid now returns correct dedicated zone. > > > Thanks, > > Saksham Srivastava > >