> On Aug. 13, 2013, 10:32 a.m., Jenkins Cloudstack.org wrote: > > Review 13534 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #121 is : > > http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/121/
failure is not because of the patch - Rajesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13534/#review25067 ----------------------------------------------------------- On Aug. 13, 2013, 10:23 a.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13534/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 10:23 a.m.) > > > Review request for cloudstack, Devdeep Singh, Murali Reddy, Ram Ganesh, and > Vijay Venkatachalam. > > > Bugs: CLOUDSTACK-3369 > > > Repository: cloudstack-git > > > Description > ------- > > issue: > if autoscale policies are created by CS , then when any network gets deleted > which got created with Netscaler as LB provider, the autoscale servers are > getting deleted. > > during delete the network ipassoc cmd executed on Netscaler resouce is > cleaning up the services which are present in the same subnet. > NetUtils.sameSubnet(vlanSelfIp, server.get_ipaddress(), vlanNetmask) is > returning true for the autoscale servers even they are not present in the > subnet because this method is returning true if any any of the ip is true. > > autoscale server don't have ip address, so true is returned and hence > removing the autoscale servers. which is causing severe issue for the > autoscale policies created in cloudstack. > > Fix: > ==== > > while executing the method deleteServersInGuestVlan which will clean up the > servers present in same subnet, check is made not to delete the autoscale > servers. > > > Diffs > ----- > > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > e42a9ea > > Diff: https://reviews.apache.org/r/13534/diff/ > > > Testing > ------- > > created accounts testa testb and created networks with NS as LB provider > network offering. > > 1. In TestA, created autoscale policy and wait for deploy the instance. > policy got created and vm got deployed. > 2. Delete the testB network, check in ns.log that autoscale servers won't get > delete. > 3. in testB network, create LB rules, and delete the network, verified > autoscale servers won't get delete. > 4. Destroy testA, TestB network, first rules got cleaned up and then the ip > assocations of the network are removed. > > > Thanks, > > Rajesh Battala > >
