----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13547/#review25115 -----------------------------------------------------------
Ship it! Ship It! - Venkata Siva Vijayendra Bhamidipati On Aug. 14, 2013, 12:46 a.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13547/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 12:46 a.m.) > > > Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati. > > > Bugs: cloudstack-4308 > > > Repository: cloudstack-git > > > Description > ------- > > For 6.3 KVM, by default, snapshot is not supported. This is managed by a > global setting KVM.snapshot.enabled. > UI needs the API support for listCapabilities response, to stop user to set > recurring snapshot when snapshot is not supported for KVM 6.3. > > > Diffs > ----- > > > api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java > a30e26c > api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java > c2996f0 > server/src/com/cloud/server/ManagementServerImpl.java 622e167 > > Diff: https://reviews.apache.org/r/13547/diff/ > > > Testing > ------- > > Before the fix, listCapabilities does not have the KVMSnapshotEnabled field: > "listcapabilitiesresponse": { > "capability": { > "securitygroupsenabled": false, > "cloudstackversion": "4.2.0-SNAPSHOT", > "userpublictemplateenabled": true, > "supportELB": "false", > "projectinviterequired": false, > "allowusercreateprojects": true, > "customdiskofferingmaxsize": 1024 > } > > I tested now with my fix, it shows: > "listcapabilitiesresponse" : { "capability" : > {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":false} > <--- default value is false; > > I then set the default value to TRUE on MS, and call listCapabilities command > again: > { "listcapabilitiesresponse" : { "capability" : > {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} > } <---- reflect the true value. > > Verified the fix through the tests. > > > Thanks, > > Fang Wang > >