> On Aug. 14, 2013, 7:48 a.m., Wei Zhou wrote: > > An issue related to this patch: > > https://issues.apache.org/jira/browse/CLOUDSTACK-4314 > > and patch: > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb59c3c > > Testing ok on devcloud.
indeed I did not test with the environment.properties on path. Sorry for the inconvenience and thank you for the fix! - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review25127 ----------------------------------------------------------- On July 24, 2013, 4:42 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11942/ > ----------------------------------------------------------- > > (Updated July 24, 2013, 4:42 a.m.) > > > Review request for cloudstack, Frank Zhang and John Burwell. > > > Repository: cloudstack-git > > > Description > ------- > > - possible resource leak closed > - file content read uses now commons-lang FileUtils > - Added unit tests > > > Diffs > ----- > > utils/src/com/cloud/utils/ProcessUtil.java c9fdf35 > utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/11942/diff/ > > > Testing > ------- > > test included > > > Thanks, > > Laszlo Hornyak > >
