----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13644/#review25346 -----------------------------------------------------------
Ship it! Applied with additional asserts - Prasanna Santhanam On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13644/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 11:10 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-4257 > > > Repository: cloudstack-git > > > Description > ------- > > Test case > integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume > failed during api call liststorage pool with unexpected result > AssertionError: Check list storage pools response for valid list > > This happens when there are no suitable pools found for migration. > Added check for empty pool list and then skip the test if no suitable hosts > are found. > > > Diffs > ----- > > test/integration/component/test_storage_motion.py eda77d1 > > Diff: https://reviews.apache.org/r/13644/diff/ > > > Testing > ------- > > If there is a single pool in the cluster, the test is skipped. > If multiple suitable hosts are found, the test passes. > > > Thanks, > > Saksham Srivastava > >
