----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25378 -----------------------------------------------------------
There are hard coded IPs for netscaler devices; its very hard to manage during the runs; we should know how many netscaler devices required for entire regression suite and that need to added like below "netscaler": { 65 "ipaddress": 'NETSCALER_DEVICE_1', 66 "username": 'nsroot', 67 "password": 'nsroot', 75 }, Its better to replace hardcodes IP from test with NETSCALER_DEVICE_1 , NETSCALER_DEVICE_2 .. - Rayees Namathponnan On Aug. 21, 2013, 10:47 a.m., Sowmya Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13680/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 10:47 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-3927 and CLOUDSTACK-3928 > > > Repository: cloudstack-git > > > Description > ------- > > Fix to add NS device in setupClass and remove in tearDown > Added a common method to perform these in common.add_netscaler() > Also fixes few account object issues in netscaler_configs. > > Patch will help in keeping each test suite independent. Otherwise we cannot > identify which NS an LB rule will be deployed in if there's more than one NS > device. > > > Diffs > ----- > > test/integration/component/test_netscaler_configs.py bcea254 > test/integration/component/test_netscaler_lb.py 3942f94 > test/integration/component/test_netscaler_lb_algo.py 477bd69 > test/integration/component/test_netscaler_lb_sticky.py 1edfd7b > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/13680/diff/ > > > Testing > ------- > > Tested locallly > > > Thanks, > > Sowmya Krishnan > >