You are right, I incorporated Alex' auto format for eclipse. Sorry for that. Being sick at home today, I will try to submit an update without it tomorrow.
regards, On Mon, Aug 26, 2013 at 6:04 AM, Dave Cahill <dcah...@midokura.com> wrote: > Hi Daan, > > I started to take a look - the diff is ~10k lines long, most of which > appears to be whitespace changes. > > Are the whitespace changes important? Without them, the patch might be a > lot easier to review. > > Thanks, > Dave. > > > > > On Sun, Aug 25, 2013 at 7:37 PM, Daan Hoogland <daan.hoogl...@gmail.com>wrote: > >> Sheng, Dave, Chiradeep and Hugo, >> >> Can you please review this? In my experience the time that this patch >> will expire is rather short, I have been resolving conflicts on this a lot. >> If now, given the 4.2 release is inconvenient, I would like to set a window >> for submitting this in which I will rebase it a couple of times so as to >> make sure it works in the end. >> >> thanks, >> Daan >> >> >> On Fri, Aug 23, 2013 at 10:48 AM, daan Hoogland >> <daan.hoogl...@gmail.com>wrote: >> >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/13771/ >>> Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Hugo >>> Trippaers, and Sheng Yang. >>> By daan Hoogland. >>> *Bugs: * CLOUDSTACK-4346 >>> *Repository: * cloudstack-git >>> Description >>> >>> After global search and replace all calls to retrieve ids for networks from >>> URIs using getHost() should be gone. Creating URI should now all use >>> appropriate calls as well so maitaining the way uris are built can now be >>> done centrally. >>> >>> Testing >>> >>> tested with old style uris in regular networks and vpc based networks as >>> well as in nicira based networks >>> test build in nonoss but not all code has probably been touched yet. or at >>> least I am unsure of that. >>> >>> Diffs >>> >>> - >>> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java >>> (07ee12d) >>> - >>> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java >>> (195cf40) >>> - >>> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java >>> (a156ae6) >>> - >>> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java >>> (7038d7e) >>> - >>> plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java >>> (59ba001) >>> - >>> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java >>> (5ab2216) >>> - >>> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java >>> (ecdec1e) >>> - >>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java >>> (54623e9) >>> - >>> plugins/network-elements/cisco-vnmc/src/com/cloud/network/element/CiscoVnmcElement.java >>> (3ae6a08) >>> - >>> plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java >>> (1733712) >>> - >>> plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java >>> (3d3d797) >>> - >>> plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java >>> (c7d0884) >>> - >>> plugins/network-elements/nicira-nvp/src/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java >>> (ff238ed) >>> - >>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java >>> (36a807f) >>> - server/src/com/cloud/api/ApiResponseHelper.java (c771431) >>> - server/src/com/cloud/configuration/ConfigurationManagerImpl.java >>> (57dc0b3) >>> - server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java >>> (e91dcfa) >>> - server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java >>> (a934024) >>> - server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java >>> (c14d5c7) >>> - server/src/com/cloud/network/NetworkManagerImpl.java (00103e3) >>> - server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java >>> (5b87d54) >>> - server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java >>> (00598dd) >>> - server/src/com/cloud/network/guru/GuestNetworkGuru.java (b0da42f) >>> - server/src/com/cloud/network/guru/PrivateNetworkGuru.java (6521cf4) >>> - server/src/com/cloud/network/guru/PublicNetworkGuru.java (d109468) >>> - >>> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java >>> (ee0d058) >>> - utils/src/com/cloud/utils/net/NetUtils.java (05b485b) >>> >>> View Diff <https://reviews.apache.org/r/13771/diff/> >>> >> >> >
