> On Aug. 27, 2013, 6:02 p.m., venkata swamy babu budumuru wrote: > > test/integration/component/test_portable_ip.py, line 817 > > <https://reviews.apache.org/r/13559/diff/1/?file=341135#file341135line817> > > > > Isn't it a better idea to check the programmed NAT rule is functioning > > properly?
Added call to get remoteSSHClient using the portable ip for which NAT rule is created. > On Aug. 27, 2013, 6:02 p.m., venkata swamy babu budumuru wrote: > > test/integration/component/test_portable_ip.py, line 168 > > <https://reviews.apache.org/r/13559/diff/1/?file=341135#file341135line168> > > > > It would be better if we prepare services dictionary for > > "portable_ip_range" manually on what range it should take. > > > > Current logic just increments the range by 1 and it expects the > > existing physical infra to be configured with that CIDR. This approach many > > not suite for everyone who fires this script. This is mandating the user of > > the scripts to have the next cidr of his public range to be configured and > > available for portable ip range testing. will directly using "untagged" vlan from the list of vlans do? Can you please explain how we can manually specify the range? As the range will be different for every setup. Please correct me if I'm wrong. Thanks. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13559/#review25613 ----------------------------------------------------------- On Aug. 14, 2013, 5:05 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13559/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 5:05 p.m.) > > > Review request for cloudstack, Murali Reddy, venkata swamy babu budumuru, > and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding new test cases for feature Portable IP > > > Diffs > ----- > > test/integration/component/test_portable_ip.py PRE-CREATION > > Diff: https://reviews.apache.org/r/13559/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
