Resending this with the appropriate email for Darren. --Alex
> -----Original Message----- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Wednesday, September 4, 2013 10:05 AM > To: Prasanna Santhanam; Darren Shepherd > Cc: Laszlo Hornyak; cloudstack; Kelven Yang > Subject: RE: Review Request 12134: removed txn attribute from DB > annotation > > Kelven and Darren should review this. > > That attribute used to be always read to determine if a method should be > intercepted at load time. My understanding is the switch to using spring as > the injection mechanism caused this to be turned off and now every single > method is intercepted, which is terrible. I don’t know if Kelven and/or > Darren has any plans to fix this. If they don’t plan on fixing it, then we > should > just commit it. > > --Alex > > From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf > Of Prasanna Santhanam > Sent: Wednesday, September 4, 2013 9:56 AM > To: Darren Shepherd; Alex Huang > Cc: Prasanna Santhanam; Laszlo Hornyak; cloudstack > Subject: Re: Review Request 12134: removed txn attribute from DB > annotation > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12134/ > > > Review request for cloudstack, Alex Huang and Darren Shepherd. > By Laszlo Hornyak. > > Updated Sept. 4, 2013, 4:55 p.m. > > Changes > > including couple reviewers > > Repository: cloudstack-git > Description > > The txn attribute was used often with the DB annotation, but it does not > have an effect on the behavior of the code since it is never read. > > - All of this references to txn removed > > - Attribute removed from annotation > > - Documentation references removed > > > Diffs > > * > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/ > api/db/dao/EngineHostDaoImpl.java (5ba65cc) > * engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java > (f071cea) > * > engine/schema/src/com/cloud/cluster/agentlb/dao/HostTransferMapDaoIm > pl.java (cff4cfc) > * engine/schema/src/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java > (b12fa9d) > * > engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java > (353402d) > * > engine/schema/src/com/cloud/dc/dao/DataCenterLinkLocalIpAddressDaoIm > pl.java (b52e373) > * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java > (d3a2409) > * > engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.j > ava (782ee0d) > * > engine/schema/src/com/cloud/dc/dao/StorageNetworkIpRangeDaoImpl.jav > a (d732e6f) > * engine/schema/src/com/cloud/host/dao/HostDaoImpl.java (41ee7a7) > * > engine/schema/src/com/cloud/network/dao/AccountGuestVlanMapDaoIm > pl.java (e7a7b34) > * > engine/schema/src/com/cloud/network/dao/ExternalFirewallDeviceDaoImp > l.java (01f8861) > * > engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceDa > oImpl.java (ea6437d) > * engine/schema/src/com/cloud/network/dao/FirewallRulesDaoImpl.java > (41f911c) > * engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java > (0f83815) > * > engine/schema/src/com/cloud/network/dao/NetworkDomainDaoImpl.java > (bbb9203) > * > engine/schema/src/com/cloud/network/dao/NetworkExternalFirewallDaoI > mpl.java (b176760) > * > engine/schema/src/com/cloud/network/dao/NetworkExternalLoadBalancer > DaoImpl.java (c29c164) > * > engine/schema/src/com/cloud/network/dao/NetworkServiceMapDaoImpl.j > ava (3cdd738) > * > engine/schema/src/com/cloud/network/dao/PhysicalNetworkDaoImpl.java > (1e26a51) > * > engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProvid > erDaoImpl.java (16a23dd) > * > engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDa > oImpl.java (7e47239) > * engine/schema/src/com/cloud/network/dao/PortProfileDaoImpl.java > (61fe52a) > * > engine/schema/src/com/cloud/network/dao/VirtualRouterProviderDaoImpl > .java (dba835f) > * engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java > (fe435c0) > * > engine/schema/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java > (518237d) > * engine/schema/src/com/cloud/network/vpc/dao/VpcDaoImpl.java > (6560b90) > * > engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java > (13c37c4) > * > engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java > (2cda547) > * > engine/schema/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapD > aoImpl.java (4b5f1b9) > * > engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.ja > va (a992181) > * > engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java > (ef8237a) > * > engine/schema/src/com/cloud/offerings/dao/NetworkOfferingServiceMap > DaoImpl.java (7282443) > * > engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java > (14b2abf) > * > engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java > (052bae4) > * engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java > (bf28410) > * engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java > (7c5c9cc) > * > engine/schema/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java > (174f283) > * > engine/schema/src/org/apache/cloudstack/region/gslb/GlobalLoadBalancer > LbRuleMapDaoImpl.java (2a6e72b) > * > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryD > ataStoreDaoImpl.java (b39f844) > * framework/db/src/com/cloud/utils/db/DB.java (f83a7ea) > * framework/db/src/com/cloud/utils/db/GenericDaoBase.java (94e5374) > * > plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/Bareme > talDhcpDaoImpl.java (8123ee0) > * > plugins/hypervisors/baremetal/src/com/cloud/baremetal/database/Bareme > talPxeDaoImpl.java (acd7f13) > * > plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsBladeDaoImpl.java > (5cb9b02) > * > plugins/hypervisors/ucs/src/com/cloud/ucs/database/UcsManagerDaoImpl.j > ava (93c0885) > * > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/Legac > yZoneDaoImpl.java (7d2d128) > * > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/dao/Vmw > areDatacenterDaoImpl.java (9f5796a) > * > plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSM > DeviceDaoImpl.java (cc25573) > * plugins/network- > elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java > (30dd06d) > * server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java (266e65f) > * server/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java > (fd3308d) > * server/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java > (8162ce8) > * server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java (ec1a017) > * server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java > (a8208dd) > * > server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl. > java (d1e8354) > * server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java > (103f04e) > * server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java (562d67d) > * server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java > (329931e) > * > server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java > (3357686) > > View Diff<https://reviews.apache.org/r/12134/diff/> >
