----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14079/#review26049 -----------------------------------------------------------
test/integration/component/test_ip_reservation.py <https://reviews.apache.org/r/14079/#comment50858> When you create a network without gateway nad subnet mask, you are using the zone level cidr. In case the zone level cidr is not 10.1.1.0/24 all the tests will fail. while creating the network use gateway and subnet mask also. test/integration/component/test_ip_reservation.py <https://reviews.apache.org/r/14079/#comment50859> Same issue here also. Use gateway and subnet mask. test/integration/component/test_ip_reservation.py <https://reviews.apache.org/r/14079/#comment50861> In case the vm creation fails the test itself will fail, it will be good to skip the test in that case. test/integration/component/test_ip_reservation.py <https://reviews.apache.org/r/14079/#comment50860> Adding an addition check of None will prevent future NPEs - Saksham Srivastava On Sept. 11, 2013, 10:09 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14079/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2013, 10:09 a.m.) > > > Review request for cloudstack, Saksham Srivastava and Prasanna Santhanam. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2266 > > > Repository: cloudstack-git > > > Description > ------- > > marvin tests for IP Address reservation within a network > > > Diffs > ----- > > test/integration/component/test_ip_reservation.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py fa4cc82 > > Diff: https://reviews.apache.org/r/14079/diff/ > > > Testing > ------- > > ran successfully on my local advanced zone setup > > > Thanks, > > Anshul Gangwar > >
