Marcus and Wido, Sorry I just saw this Email. I will create a JIRA ticket for them (both code and docs) later. I regarded it as an improvement, not a new feature, this is why I cherry-picked it into 4.1 branch. If you guys object it, I will revert it.
Marcus, could you create tickets for the issues you mentioned? The commit is in 4.2 and master branch as well. We need to fix potential issues. Kind Regards, Wei ZHOU Innovation Engineer Cloud, LeaseWeb B.V. w.z...@leaseweb.com -----Original Message----- From: Wido den Hollander [mailto:w...@widodh.nl] Sent: 16 September 2013 09:22 To: dev@cloudstack.apache.org Cc: Wei Zhou Subject: Re: 4.1 new feature post release? On 09/15/2013 07:32 AM, Marcus Sorensen wrote: > Hi guys, I was just pulling in updates from the 4.1 branch and noticed > commit 706e23623c3227d92ae498529166ca73d2a2bf4e, This looks like a new > feature. There's not a bug attached to it. It seems to allow admins to > set the CPU mode for KVM guests, e.g. host-passthrough, which makes > the VM show the actual CPU model of the host (and breaks live > migration in some cases), etc. > > I see no reason off hand why this should have been cherry-picked into > 4.1. It's been awhile, and I'm not sure whether or not we'll release > a 4.1.2, but we may want to review/revert it if we don't find out why > it was picked. > Good point. 4.1.2 release or not, there shouldn't be any new features in the 4.1 branch. Wei, can you comment on this? Wido > commit 706e23623c3227d92ae498529166ca73d2a2bf4e > Author: JijunLiu <jiju...@gmail.com> > Date: Sun Jul 14 11:21:39 2013 +0800 > > Add cpu model for kvm guest.Now all the kvm guest's cpu model is > 'QEMU Virtual CPU version xxx'. This will affect the activati > > Signed-off-by: Wei Zhou <w.z...@leaseweb.com> > (cherry picked from commit > 2903bb5fd9d59803980102854d11e33ebe56088b) >
