Agree with Daan unit tests would be nice. +1
On 26 September 2013 07:59, Wei ZHOU <ustcweiz...@gmail.com> wrote: > +1 > > > 2013/9/25 Chip Childers <chipchild...@apache.org> > >> Hi all! >> >> As stated in other threads, Juniper is proposing the donation of a >> Contrail plugin to Apache CloudStack. The code itself has been posted >> to reviewboard [1]. The design has been documented by Pedro [2]. >> >> [1] https://reviews.apache.org/r/14325/ >> [2] >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Contrail+network+plugin >> >> I'm calling a vote here, so that we have a formal consensus on accepting >> the code into the project. As I've suggested earlier, I'd like us to >> accept the code into a branch, and then work through any technical >> concerns / reviews / changes prior to a master branch merge. >> >> So... voting will end in ~72 hours. As this is a technical decision, >> committer and PMC votes are binding. >> >> -chip >> >> >> Votes please! >> >> [ ] +1 - Accept the donation >> [ ] +/-0 - No strong opinion >> [ ] -1 - Do not accept the donation >>
