----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13770/#review26441 -----------------------------------------------------------
Ship it! Ship It! - Brian Federle On Aug. 28, 2013, 7:46 a.m., bo wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13770/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 7:46 a.m.) > > > Review request for cloudstack, Brian Federle and bharat kumar. > > > Bugs: CLOUDSTACK-3363 > > > Repository: cloudstack-git > > > Description > ------- > > 1.The loading screen won't disappear when delete the events or alerts with > incorrect parameters ,Because there is no handling for exception in the js > code. > 2.Error messages are not completely correct, it should be "Either type or > enddate must be specified". > > > Diffs > ----- > > ui/scripts/events.js 46d45c0 > > Diff: https://reviews.apache.org/r/13770/diff/ > > > Testing > ------- > > 1.The loading screen will disappear when close the error message dialog. > 2.The error message will be "Either type or enddate must be specified". > > > Thanks, > > bo wang > >
