----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14285/ -----------------------------------------------------------
(Updated Sept. 27, 2013, 8:34 p.m.) Review request for cloudstack. Changes ------- Uploaded a .patch instead of a .diff so that it has the git commit header. Repository: cloudstack-git Description ------- See https://issues.apache.org/jira/browse/CLOUDSTACK-1579 I have added the logic and hooks for allowing list views to indicate they support multiselect rows and added hooks for list view actions to indicate they are a multiselect action. The data for the selected rows is stored and passed to callbacks in the same 'context' variable as with non-multiselect callbacks, so implementing multiselect should remain consistent. This is purely a functional update and there is cosmetic work to be done shortly by someone other than myself (likely Brian Federle). Some notes for those interested: - $.remove() vs $.detach(): remove will delete the DOM element while detach simply removes it from view, allowing it to be added later and re-used - List views can indicate they support multi-select with 'multiSelect: true' - Actions can indicate they are a multi-select action with 'isMultiSelectAction: true' and 'isHeader: true' - This patch also includes a new list view flag called 'noActionCol' which intentional hides the 'Quickview' on rows which can be handy when the rows become too wide and look weird - Currently, when one or more multi-select rows are selected, non-multi-select actions (such as Add) are hidden and replaced with the multi-select actions, however the idea was proposed to add another row of buttons below the non-multi-select buttons when this is the case - this is still open for discussion as there was no consensus Diffs (updated) ----- ui/plugins/netapp PRE-CREATION ui/scripts/ui/widgets/dataTable.js 66d7095 ui/scripts/ui/widgets/listView.js 076b3ab Diff: https://reviews.apache.org/r/14285/diff/ Testing ------- Testing has been done in conjunction with a UI plugin I am developing. Additional testing will be performed as this is integrated into existing parts of the UI. Thanks, Chris Suich
