----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14398/#review26462 -----------------------------------------------------------
Looks alright, please add spark404 to reviewers. just in case I missed something. - daan Hoogland On Sept. 28, 2013, 4:38 p.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14398/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 4:38 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - removed methods that were not used > - parseLong, parseInt and parseFloat replaced with the commons-lang > NumberUtils call > - Test for the remaining methods > > > Diffs > ----- > > utils/src/com/cloud/utils/NumbersUtil.java 035239a > utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a > > Diff: https://reviews.apache.org/r/14398/diff/ > > > Testing > ------- > > tests included > > > Thanks, > > Laszlo Hornyak > >
