> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > the tests are skipped when committing. > > Sheng Yang wrote: > No, looks like the test case added storage tag instead of host tag. Don't > know how it could run. > > Ashutosh Kelkar wrote: > The tests don't add the tags to the host themselves. The host tagging is > done manually before running the tests. The tests don't create any tags > storage or host. Could you please point me to where you think this is > happening in the tests? > > Sheng Yang wrote: > The test create service offering with storage tag "host1" or "host2". How > can it get the deployment done with host tag "host1" and "host2"???
Again, the test case failed on hosts with host tag "host1" and "host2", because the deployment cannot found *storage tag* "host1" and "host2". I don't understand how did the test pass. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review26402 ----------------------------------------------------------- On Sept. 18, 2013, 2:28 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14058/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 2:28 p.m.) > > > Review request for cloudstack, Girish Shilamkar, venkata swamy babu > budumuru, and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Added 10 tests for VPC VM liftcycle on tagged hosts > > New class added : TestVMLifeCycleDiffHosts > > def test_01_deploy_instance_in_network(self): > def test_02_stop_instance_in_network(self): > def test_03_start_instance_in_network(self): > def test_04_reboot_instance_in_network(self): > def test_05_destroy_instance_in_network(self): > def test_06_recover_instance_in_network(self): > def test_07_migrate_instance_in_network(self): > def test_08_user_data(self): > def test_09_meta_data(self): > def test_10_expunge_instance_in_network(self): > > This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with > tag 'host1' and 1 host with tag 'host2') > > > Diffs > ----- > > test/integration/component/test_vpc_vm_life_cycle.py 9844c1f > > Diff: https://reviews.apache.org/r/14058/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
