----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review26684 -----------------------------------------------------------
It seems this patch includes a lot of line length based reformatting in the unit tests. Can you narrow the patch down to just what is really needed to change. - Darren Shepherd On Oct. 4, 2013, 11:12 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14451/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 11:12 a.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-4807 > > > Repository: cloudstack-git > > > Description > ------- > > - tests added for mac2Long, byte2Mac, long2Mac, ip2Long and long2Ip > - isWindows static method removed - it was not used > - minor changes in the implementations of the tested methods > > > Diffs > ----- > > utils/src/com/cloud/utils/net/NetUtils.java 1e72e22 > utils/test/com/cloud/utils/net/NetUtilsTest.java 3cfc98f > > Diff: https://reviews.apache.org/r/14451/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Laszlo Hornyak > >
