----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14591/#review27122 -----------------------------------------------------------
utils/src/com/cloud/utils/net/NetUtils.java <https://reviews.apache.org/r/14591/#comment52770> This patch is failed to apply on master. utils/src/com/cloud/utils/net/NetUtils.java <https://reviews.apache.org/r/14591/#comment52771> Please remove the tabs here - Jayapal Reddy On Oct. 11, 2013, 10:53 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14591/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 10:53 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali > Reddy. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811 > > > Repository: cloudstack-git > > > Description > ------- > > The UI Wizard was allowing Invalid CIDR in public traffic page while creating > a zone and back end was also not checking the correctness of the CIDR before > creating a zone. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca > utils/pom.xml f4ac12b > utils/src/com/cloud/utils/net/NetUtils.java 05b485b > > Diff: https://reviews.apache.org/r/14591/diff/ > > > Testing > ------- > > Testing is done through UI > For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask > value > Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 > and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range > for the given gateway and net mask values. > > > Thanks, > > Damodar Reddy Talakanti > >
