> On Oct. 19, 2013, 4:42 p.m., Koushik Das wrote: > > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java, line 28 > > <https://reviews.apache.org/r/14305/diff/2/?file=366343#file366343line28> > > > > Why this is changed to protected?
these are made protected so that they are used in the derived class CreateSSHKeypair response. SSHkeypairResponse is base class (where name, fingerprint are defined as protected) CreateSSHkeypairResponse is derived class (where name, fingerprint are used from base class) If they are defined as private we cannot use them in derived class. - Harikrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14305/#review27218 ----------------------------------------------------------- On Oct. 18, 2013, 12:43 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14305/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2013, 12:43 p.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-4493 > https://issues.apache.org/jira/browse/CLOUDSTACK-4493 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response > (private key) > Changing the response object of register and list ssh keypairs APIs > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java > 56bec7e > api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 > > Diff: https://reviews.apache.org/r/14305/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
