> On Oct. 23, 2013, 7:25 a.m., Prasanna Santhanam wrote: > > tools/marvin/marvin/cloudstackConnection.py, line 169 > > <https://reviews.apache.org/r/14869/diff/1/?file=369602#file369602line169> > > > > can we please use # for inline comments in code and """ quoted > > doc-string comments under methods, classes and modules?
Sometimes, adding #comments for multiline comments decreases readability - Santhosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14869/#review27366 ----------------------------------------------------------- On Oct. 23, 2013, 6:33 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14869/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 6:33 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > 1. Currently, there was one issue found in requests library. > 2. Added change to strip the command string passed to marvin request command > 3. Removed few unwanted code. > 4. Made the testclient uniform to pass both mgt and dbsrv details. > > > Diffs > ----- > > tools/marvin/marvin/cloudstackConnection.py df88fa2 > tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf > tools/marvin/marvin/codegenerator.py 96729f6 > tools/marvin/marvin/configGenerator.py 45c3d69 > tools/marvin/marvin/deployDataCenter.py 6b5f64b > > Diff: https://reviews.apache.org/r/14869/diff/ > > > Testing > ------- > > Tested changes on simulator, it created entities post the run so it seems > tests were working fine. > > > Thanks, > > Santhosh Edukulla > >
