-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15021/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 11:57 a.m.)
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Changes
-------
1. Removed few unwanted imports
2. Added default config dir path
3. Added config directory to setup.py
4. Added config file path to be pickedup dynamically.
Repository: cloudstack-git
Description
-------
Added Configuration Support to Marvin.
1. It provides the basic configuration facilities to marvin.
2. User can just add configuration files for his tests, deployment
etc, under one config folder before running their tests.
cs/tools/marvin/marvin/config.
They can remove all hard coded values from code and separate
it out as config at this location.
Either add this to the existing setup.cfg as separate section
or add new configuration.
3. This will thus removes hard coded tests and separate
data from tests.
4. This API is provided as an additional facility under
cloudstackTestClient and users can get the
configuration object as similar to apiclient,dbconnection
etc to drive their test.
5. They just add their configuration for a test,
setup etc,at one single place under configuration dir
and use "getConfigParser" API of cloudstackTestClient
It will give them "configObj".They can either pass their own
config file for parsing to "getConfig" or it will use
default config file @ config/setup.cfg.
6. They will then get the dictionary of parsed
configuration and can use it further to drive their tests or
config drive
7. Test features, can drive their setups thus removing hard coded
values. Configuration default file will be under config and as
setup.cfg.
8. Users can use their own configuration file passed to
"getConfig" API,once configObj is returned.
Another such case where we are using sed or bash script is in between a build
run for replacing hard coded ldap ip for region\setup specific. We can now
change all parameters before run under configuration, the test features will
use configuration object and thus values, rather hard coded strings which
avoids replacement through shell script.
Also, did few naming convention changes. Its better to follow uniform naming
conventions. Currently, wherever iam seeing a specific notation not followed.
We are incorporating those changes.
ToDo:
clean up of current config at places, making configuration required for
marvin\tests unified and available at one place and clean up of files\code
related to it.
Diffs
-----
tools/marvin/marvin/cloudstackTestClient.py be93f35
tools/marvin/marvin/config/setup.cfg PRE-CREATION
tools/marvin/marvin/configGenerator.py 0cfad30
tools/marvin/marvin/integration/lib/utils.py 7d662af
Diff: https://reviews.apache.org/r/15021/diff/
Testing
-------
Basic check to retrieve configuration values is done.
File Attachments (updated)
----------------
Added changes as discussed
https://reviews.apache.org/media/uploaded/files/2013/10/31/0001-Fixed-Bug-4899_2.patch
Thanks,
Santhosh Edukulla
