----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15128/ -----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Bugs: CLOUDSTACK-4866 https://issues.apache.org/jira/browse/CLOUDSTACK-4866 Repository: cloudstack-git Description ------- added group and domain params to importLdapUsers api call. If a group param is present, importUsers will import ldap users only from that group. If a domain param is present, it will create the users in that domain. it will fallback to group or OU of the ldap user or the ROOT domain in the order Diffs ----- plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java f872247 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java a08dccb plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManager.java 683822d plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 90a79b3 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 47697c9 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 66b4673 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy cc849de plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy d04b094 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy 321e1af plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy 339923e server/src/com/cloud/configuration/Config.java 3fdc343 setup/db/db/schema-421to430.sql 0de9dfd Diff: https://reviews.apache.org/r/15128/diff/ Testing ------- Yes. Added unit tests. Thanks, Rajani Karuturi