Prasanna, This looks alright to me. As I am not an expert on bvt; Can you give some clues as what to look for in reviews of this kind of code?
otherwise ship it, Daan On Mon, Nov 4, 2013 at 6:22 PM, Santhosh Edukulla < santhosh.eduku...@citrix.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15208/ > Review request for cloudstack and Prasanna Santhanam. > By Santhosh Edukulla. > > *Updated Nov. 4, 2013, 5:22 p.m.* > Summary (updated) > > Added fix for bug 5032. Provides custom assert facility to test features. > Added the new assert to cloudstackTestCase > > *Bugs: * > CLOUDSTACK-5032<https://issues.apache.org/jira/browse/CLOUDSTACK-5032> > *Repository: * cloudstack-git > Description (updated) > > Added custom assert by name "assertElementInList" to cloudstackTestCase, this > will help users to simplify their asserts. > Allows users to dump custom message for these asserts. > Changed the Interface for "verifyElementInList" to take additional argument. > > > > Diffs > > - tools/marvin/marvin/cloudstackTestCase.py (85ef542) > - tools/marvin/marvin/integration/lib/utils.py (d53c1ae) > > View Diff <https://reviews.apache.org/r/15208/diff/> >
