> On Nov. 5, 2013, 5:26 a.m., Marcus Sorensen wrote: > > I can't remember why, exactly, but I seem to remember we switched > > everything over to domain lookups by name awhile back (maybe in 4.1). I > > think it was just because it seemed like a convoluted abstraction to take > > the vmname, convert it to a uuid, and then lookup by that. We may not even > > register a uuid any longer, I don't remember.
ummm. Is there anything I can do to merge this commit? - Yoshikazu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/#review28175 ----------------------------------------------------------- On Nov. 5, 2013, 5:17 a.m., Yoshikazu Nojima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15238/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 5:17 a.m.) > > > Review request for cloudstack, Marcus Sorensen, Toshiaki Hatano, and Wido den > Hollander. > > > Bugs: CLOUDSTACK-5039 > https://issues.apache.org/jira/browse/CLOUDSTACK-5039 > > > Repository: cloudstack-git > > > Description > ------- > > * Issue to be solved: > > Live migration failed with following error message: > > 2013-11-05 04:39:29,345 DEBUG [kvm.resource.LibvirtComputingResource] > (agentRequest-Handler-1:null) Can't migrate domain: Domain not found: no > domain with matching uuid '87c06b76-5ee6-3f1b-8c89-54e75de6bd3d' > > It seems CloudStack doesn't specify correct UUID. > This commit revert the domain lookup code change made in the commit ( > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=203587a06f63f23d487ae65dcf5c397cd2702166;hp=94ee9ae676ef8d0202e7fa617e712352a934ffcb;hb=a709f34f;hpb=5410901aebed4ada581b853e0ca02d9f855a68f1 > ). > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > e3f60f2 > > Diff: https://reviews.apache.org/r/15238/diff/ > > > Testing > ------- > > I confirmed live migration works. > > > Thanks, > > Yoshikazu Nojima > >
