-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15263/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 1:44 p.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Added few corrections.
Bugs: CLOUDSTACK-5056
https://issues.apache.org/jira/browse/CLOUDSTACK-5056
Repository: cloudstack-git
Description
-------
1. The library( remoteSSHClient ) in its current form has some issues. Fixed
few of them. As part of that, did clean up of the code.
2. Added tcp timeout flag as an additional parameter to help establish the tcp
connections and retry if failed. It retries even otherwise failed.
3. Renamed few variables and maintained uniform usage and convention.
4. Added few new member functions runCommand,createConnection
5. Current, way of creating connection and raising exception from constructor
along with return was removed and added a new way of handling it.
6. Currently, result list was returned for execute command, but we dont know
the status of command execution, whether the output contains error or output
etc. Now, provided more information in the return with new implementation.
7. Added few codes for proper return status.
TODO:
1. Remove establishing connection from constructor altogether. This will effect
the current modules using it.
2. Need to change is_server_ssh_ready function for proper and adequate checks,
currently the name and functionality is little different. It can add more
adequate checks before returning ssh object.
Diffs
-----
tools/marvin/marvin/codes.py b6580d0
tools/marvin/marvin/integration/lib/utils.py 4d048f0
tools/marvin/marvin/remoteSSHClient.py fea9b12
Diff: https://reviews.apache.org/r/15263/diff/
Testing
-------
File Attachments (updated)
----------------
Added New File
https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch
Thanks,
Santhosh Edukulla
