----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15264/ -----------------------------------------------------------
(Updated Nov. 6, 2013, 2:08 p.m.) Review request for cloudstack and Hugo Trippaers. Changes ------- Added cloudstack as review group Bugs: 1125389 https://issues.apache.org/jira/browse/1125389 Repository: cloudstack-git Description ------- In org.?apache.?cloudstack.?network.?contrail.?management.?ContrailManagerImpl.?getPhysicalNetworkName(com.?cloud.?network.?dao.?PhysicalNetworkVO): The return value of this method should be checked. (From FindBugs™ description) (CWE-440) Diffs ----- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java ae9bba9 Diff: https://reviews.apache.org/r/15264/diff/ Testing ------- Thanks, Wilder Rodrigues