----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15349/#review28786 -----------------------------------------------------------
Ship it! Ship It! - Nitin Mehta On Nov. 13, 2013, 5:35 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15349/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 5:35 a.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: Cloudstack-5077. > https://issues.apache.org/jira/browse/Cloudstack-5077. > > > Repository: cloudstack-git > > > Description > ------- > > > 1.) This includes the change to reserve cpu and memory only when > vmware.reserve.cpu/mem is true, regardless of overcommit. > 2.) populate the default value of the cpu overcommit at cluster level form > the global setting when up grading. > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 > engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 4921925 > server/src/com/cloud/configuration/Config.java f06b463 > setup/db/db/schema-420to421.sql 302d44a > > Diff: https://reviews.apache.org/r/15349/diff/ > > > Testing > ------- > > > Thanks, > > bharat kumar > >
