----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28803 -----------------------------------------------------------
Ship it! Ship It! - Girish Shilamkar On Nov. 13, 2013, 2:06 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15478/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 2:06 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5156 > https://issues.apache.org/jira/browse/CLOUDSTACK-5156 > > > Repository: cloudstack-git > > > Description > ------- > > component.test_stopped_vm.TestDeployVM.test_08_deploy_attached_volume > This test was failing during detaching volume from a virtual machine. > But the volume which was being detached from the virtual machine was obtained > from listing the volumes belonging to the same account and picking up the > first element in the list which does not guarantee that it is the same volume > belonging to the VM as the same account is used in many test cases. > > Passed virtualmachineid parameter to get the exact volume belonging to the > virtual machine and now the test case works. > > > Diffs > ----- > > test/integration/component/test_stopped_vm.py 2586c0b > > Diff: https://reviews.apache.org/r/15478/diff/ > > > Testing > ------- > > Tested locally on XenServer basic zone setup. > > Log: > > ==> client.log <== > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 20930 > 0b9-0f42-4c73-941d-93c75b168203 > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deploying instance in the account: > test-P6HACO > 2013-11-13 02:04:08,353 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-P6HACO > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 8f68e > fd6-9d64-44e1-9998-ce03d0158cb8 > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Fetching DATADISK details for instance: > 8f68efd6-9d64-44e1-999 > 8-ce03d0158cb8 > 2013-11-13 02:04:08,418 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Detaching the disk: DATA-263 > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Datadisk DATA-263 detached! > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Attaching volume to instance: > 209300b9-0f42-4c73-941d-93c75b16 > 8203 > 2013-11-13 02:04:18,668 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleaning up the resources > 2013-11-13 02:04:33,825 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleanup complete! > > ==> result.log <== > Test Deploy Virtual Machine with no startVM parameter ... skipped 'Skip' > test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) > Test Upload volume and attach to VM in stopped state ... skipped 'Skip' > test_vm_per_account (test_stopped_vm.TestVMAccountLimit) > Test VM limit per account ... skipped 'Skip' > > ---------------------------------------------------------------------- > Ran 17 tests in 56.691s > > OK (skipped=16) > > > Thanks, > > Gaurav Aradhye > >
