----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15569/ -----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5179 https://issues.apache.org/jira/browse/CLOUDSTACK-5179 Repository: cloudstack-git Description ------- component.test_stopped_vm.TestDeployVM.test_08_deploy_attached_volume test case was failing while detaching volume because the volume was not listed properly. List volumes should accept the virtualmachineid parameter to correctly list the volume belonging to the virtual machine, otherwise the volume which we are detaching from virtual machine may belong to other virtual machine, in this case test case will fail. Diffs ----- test/integration/component/test_stopped_vm.py 4514bb7 Diff: https://reviews.apache.org/r/15569/diff/ Testing ------- Tested locally on XenServer Basic Zone setup. test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... ==> client.log <== 2013-11-14 19:27:10,018 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-6MG5KF 2013-11-14 19:27:10,039 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for virtual machine: 9631c 64f-a7ba-488b-951b-c425f00e1ce3 2013-11-14 19:27:10,039 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Deploying instance in the account: test-6MG5KF 2013-11-14 19:27:31,205 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-6MG5KF 2013-11-14 19:27:31,240 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for virtual machine: 7e3de e7d-29ce-425c-95e4-e8f85143254c 2013-11-14 19:27:31,240 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Fetching DATADISK details for instance: 7e3dee7d-29ce-425c-95e 4-e8f85143254c 2013-11-14 19:27:31,266 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Detaching the disk: DATA-32 2013-11-14 19:27:36,379 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Datadisk DATA-32 detached! 2013-11-14 19:27:36,379 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Attaching volume to instance: 9631c64f-a7ba-488b-951b-c425f00e 1ce3 2013-11-14 19:27:41,530 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Cleaning up the resources 2013-11-14 19:28:42,227 - DEBUG - test_08_deploy_attached_volume (test_stopped_vm.TestDeployVM) - Cleanup complete! ==> result.log <== ok Thanks, Gaurav Aradhye