Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null

[Yichi Lu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15633/
-----------------------------------------------------------

Review request for cloudstack.


Bugs: 5079
    https://issues.apache.org/jira/browse/5079


Repository: cloudstack-git


Description
-------

CLOUDSTACK-5079. When using api call, listConfigurations, and specifying 
clusterid, some keys may not have values. this causes a null pointer to be 
returned.
Add guard against null pointer in 
server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
 If a null pointer is returned from 
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
 set value to 'NULL'.


Diffs
-----

  server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada 

Diff: https://reviews.apache.org/r/15633/diff/


Testing
-------

tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, 
&listConfigurations&zoneid=xxx,  &listConfigurations&category=Advanced


Thanks,

Yichi Lu