> On Nov. 17, 2013, 4:26 p.m., Ian Duffy wrote: > > Rajani, > > > > This introduces mixing of tabs and spaces within the javascript files. Can > > you please adjust to use spaces only? > > > > Other than that it looks good. > > I will ship once I see the above fixed. > > > > Thanks, > > Ian > > Rajani Karuturi wrote: > Hi Ian, > Thanks for the review. My editor shows them as spaces only. I did a > "Convert indentation to spaces" on the js files and didnt see any new changes. > I use sublimetext3 with spaces:4 setting. > Can you tell me on which file you are seeing mixed tabs and spaces? > > -Rajani
Sure, all of the *.js files that you modified. You'll see it in accountWizard.js in this screenshot: https://people.apache.org/~duffy/tabvsspace.png - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15572/#review29022 ----------------------------------------------------------- On Nov. 15, 2013, 11:50 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15572/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 11:50 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Ian Duffy. > > > Bugs: CLOUDSTACK-4866 > https://issues.apache.org/jira/browse/CLOUDSTACK-4866 > > > Repository: cloudstack-git > > > Description > ------- > > added LDAP group name label in add account wizard > > changed the parameter for domain in api importLdapUser from name to UUID > > improved error handling > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties 5885bd0 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java > 063db0e > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy > 0455640 > ui/dictionary.jsp 0ccfc23 > ui/scripts/accountsWizard.js 70ef082 > ui/scripts/docs.js a3151b1 > ui/scripts/ui-custom/accountsWizard.js 358e29c > > Diff: https://reviews.apache.org/r/15572/diff/ > > > Testing > ------- > > unit testing for all the java changes and manual testing for UI changes is > done. > > > Thanks, > > Rajani Karuturi > >
