----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15647/#review29484 -----------------------------------------------------------
Ship it! d19688103ba7f7c53c264fb67cb534dd693c95cd (remarks are about the old code not this patch) awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java <https://reviews.apache.org/r/15647/#comment56786> code in comment (not as comment). this should be removed awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java <https://reviews.apache.org/r/15647/#comment56787> code in comment (not as comment). this should be removed awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java <https://reviews.apache.org/r/15647/#comment56788> code in comment (not as comment). this should be removed - daan Hoogland On Nov. 26, 2013, 1:06 p.m., Wilder Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15647/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 1:06 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fixing coverity issues related to resource leak on FileInputStream being > created anonymously. > > This patch fixed the following Coverity issues: > > cv_1116497 > cv_1116681 > cv_1116694 > cv_1116567 > cv_1116495 > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d > awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java > deb886f > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 > framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java > 0d28e09 > > Diff: https://reviews.apache.org/r/15647/diff/ > > > Testing > ------- > > A build full build was executed on top of the branch created for these > changes. After committed and patched, the a brand new branch was created from > Master and patched with this patch. Everything worked fine. > > No new feature was added. > > > Thanks, > > Wilder Rodrigues > >
