----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/#review29485 -----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15875/#comment56789> Is there a guarantee that the parameter is castable to Long? - daan Hoogland On Nov. 27, 2013, 11:12 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15875/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 11:12 a.m.) > > > Review request for cloudstack, Jayapal Reddy and Koushik Das. > > > Bugs: CLOUDSTACK-5160 > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Repository: cloudstack-git > > > Description > ------- > > use a map to specify the custom parameters in the deployvm api Instead of one > parameter for each. > > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java 444c47a > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e > engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 > server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 > > Diff: https://reviews.apache.org/r/15875/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > >
