----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15999/#review29727 -----------------------------------------------------------
Commit b1462e826aef2980ec12fef2fb89914c6a8606c5 in branch refs/heads/4.2 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b1462e8 ] CLOUDSTACK-5364: Resolving network cleanup issue in egress fw rules test cases - ASF Subversion and Git Services On Dec. 4, 2013, 12:12 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15999/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 12:12 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5364 > https://issues.apache.org/jira/browse/CLOUDSTACK-5364 > > > Repository: cloudstack-git > > > Description > ------- > > Following test cases failed: > test_11_egress_fr11 > test_11_1_egress_fr11 > > They failed due to two isolated networks were being created in an account, > that happened in case where network from the previous test did not get > deleted. > > Added loop in tearDown to check if all the vms in the network are expunged > before deleting the network, so that the network gets deleted properly before > execution of next test case. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py 6dcc2c4d > > Diff: https://reviews.apache.org/r/15999/diff/ > > > Testing > ------- > > Tested locally on KVM advances setup. > > Log: > > test_01_1_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is NOT > allowed. ... skipped 'Skip' > test_01_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is allowed. > ... skipped 'Skip' > test_02_1_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... skipped 'Skip' > test_02_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... skipped 'Skip' > test_03_1_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... > skipped 'Skip' > test_03_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... > skipped 'Skip' > test_04_1_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... skipped > 'Skip' > test_04_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... skipped > 'Skip' > test_05_1_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... skipped 'Skip' > test_05_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... skipped 'Skip' > test_06_1_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule without CIDR ... skipped 'Skip' > test_06_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule without CIDR ... skipped 'Skip' > test_07_1_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule without End Port ... skipped 'Skip' > test_07_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Create Egress rule without End Port ... skipped 'Skip' > test_08_1_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... skipped 'Skip' > test_08_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... skipped 'Skip' > test_09_1_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Delete Egress rule ... skipped 'Skip' > test_09_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Delete Egress rule ... skipped 'Skip' > test_10_1_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip' > test_10_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip' > test_11_1_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_11_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_12_1_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Reboot Router ... skipped 'Skip' > test_12_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Reboot Router ... skipped 'Skip' > test_13_1_egress_fr13 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Redundant Router : Master failover ... skipped 'Skip' > test_13_egress_fr13 (test_egress_fw_rules_fixed.TestEgressFWRules) > Test Redundant Router : Master failover ... skipped 'Skip' > > ---------------------------------------------------------------------- > Ran 26 tests in 1065.780s > > OK (skipped=24) > > > Thanks, > > Ashutosh Kelkar > >
