----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16036/#review29802 -----------------------------------------------------------
Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Dec. 5, 2013, 6:57 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16036/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 6:57 a.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5377 > https://issues.apache.org/jira/browse/CLOUDSTACK-5377 > > > Repository: cloudstack-git > > > Description > ------- > > component.test_snapshots.TestSnapshots.test_04_delete_snapshot failed with > "Check list response returns a valid list". > > The test case is failing while listing the data disks attached to virtual > machine, but the data disk was being detached from the VM in test_07. > > Removed this dependency between the test cases. > > > Diffs > ----- > > test/integration/component/test_snapshots.py 0a82fc1 > > Diff: https://reviews.apache.org/r/16036/diff/ > > > Testing > ------- > > Ran the test case along with the test case on which it was previously > dependent. > > Log: > test_01_createVM_snapshotTemplate > (test_snapshots.TestCreateVMSnapshotTemplate) > Test create VM, Snapshot and Template ... skipped 'skip' > test_05_snapshot_events (test_snapshots.TestSnapshotEvents) > Test snapshot events ... skipped 'skip' > test_01_volume_from_snapshot (test_snapshots.TestSnapshots) > Test Creating snapshot from volume having spaces in name(KVM) ... skipped > 'skip' > test_02_snapshot_data_disk (test_snapshots.TestSnapshots) > Test Snapshot Data Disk ... skipped 'skip' > test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots) > Test snapshot from detached disk ... ok > test_04_delete_snapshot (test_snapshots.TestSnapshots) > Test Delete Snapshot ... ok > test_07_template_from_snapshot (test_snapshots.TestSnapshots) > Create Template from snapshot ... skipped 'skip' > > ---------------------------------------------------------------------- > Ran 7 tests in 216.329s > > OK (skipped=5) > > > Thanks, > > Gaurav Aradhye > >
