-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15897/
-----------------------------------------------------------
(Updated Dec. 5, 2013, 7:04 p.m.)
Review request for cloudstack and Murali Reddy.
Changes
-------
Added patch for 4.3
Bugs: CLOUDSTACK-5296
https://issues.apache.org/jira/browse/CLOUDSTACK-5296
Repository: cloudstack-git
Description
-------
This patch adds support for trust chains in the netscaler.
I initially planned on using the 10.1 API's "bundle" feature but during my
testing I found that was not working. So I am doing the chain linking myself.
Also NS can have only one entity of a certificate ie lets say two different
users try to add the same certificate on the netscaler only one of them will go
through. The other one says resouce already exists even though they have
different files.
This can be a problem in trust chains where the chain can be shared between
multiple accounts/certificates. So, I am using the figerprint as an identifier
of a certificate and making sure that we delete it only when no one references
it.
Diffs (updated)
-----
.gitignore 8e3b052
api/src/com/cloud/network/lb/LoadBalancingRule.java 39c969c
engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java af0d970
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
e48d31d
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a1650e0
server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 74adb37
utils/src/com/cloud/utils/security/CertificateHelper.java 8344d72
Diff: https://reviews.apache.org/r/15897/diff/
Testing
-------
Testing was done a a 3-length chain with a root, intermediate and a client
certificate. Two clients share the same intermediate certificate.
Thanks,
Syed Ahmed
