----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16295/#review30609 -----------------------------------------------------------
Ship it! 55a6df450153063a25f05d24f79587371f2082b1 - daan Hoogland On Dec. 16, 2013, 3:49 p.m., Antonio Fornie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16295/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 3:49 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Resources leaks, refactoring and testing for sanity check in cloud-usage > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade2214to30.java 62fdcf1 > framework/db/src/com/cloud/utils/db/TransactionLegacy.java b36c027 > usage/pom.xml a0055cc > usage/src/com/cloud/usage/UsageSanityChecker.java 34032bc > usage/test/com/cloud/usage/UsageSanityCheckerIT.java PRE-CREATION > usage/test/com/cloud/usage/UsageSanityCheckerTest.java PRE-CREATION > usage/test/resources/cloud1.xml PRE-CREATION > usage/test/resources/cloud2.xml PRE-CREATION > usage/test/resources/cloud3.xml PRE-CREATION > usage/test/resources/cloud_usage1.xml PRE-CREATION > usage/test/resources/cloud_usage2.xml PRE-CREATION > usage/test/resources/cloud_usage3.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/16295/diff/ > > > Testing > ------- > > Whole Maven lifecycle, Unit Tests and Integrations Tests > > > Thanks, > > Antonio Fornie > >