----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16293/#review30882 -----------------------------------------------------------
Edison has fixed this bug, so this patch is not needed. - Min Chen On Dec. 16, 2013, 1:19 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16293/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 1:19 p.m.) > > > Review request for cloudstack and Min Chen. > > > Bugs: CLOUDSTACK-5264 > https://issues.apache.org/jira/browse/CLOUDSTACK-5264 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5264: Xenserver - Full Snapshots are not being created even after > snapshot.delta.max is exceeded > > Fixed the code that decides whether to take full snapshot or not based on the > configuration parameter "snapshot.delta.max" > > > Diffs > ----- > > core/src/org/apache/cloudstack/storage/to/SnapshotObjectTO.java 34e977c > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java > 67cc324 > > engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java > 69900af > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java > 5a19aee > server/src/com/cloud/storage/CreateSnapshotPayload.java 3bc571e > > Diff: https://reviews.apache.org/r/16293/diff/ > > > Testing > ------- > > Tested locally by setting the value of "snapshot.delta.max" to 4 and checked > for 4 delta snapshots. > > > Thanks, > > Harikrishna Patnala > >
