> On Dec. 30, 2013, 10:33 p.m., Sheng Yang wrote: > > Hi Suresh, > > > > There is no way we can review this since it's not added as diff files. > > > > Please re-do the upload as diff and make sure it in the proper format that > > can be reviewed. "View diff" button should be shown. > > > > Also you'd better rebase the patch to the latest. > > > > Thanks.
And rebase on MASTER. Thanks. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16274/#review30979 ----------------------------------------------------------- On Dec. 30, 2013, 10:33 p.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16274/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2013, 10:33 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - Juniper Contrail VRouter VPC Implementation. > - Network Policy Support added. > - Contrail Public Network Offerring added. Earlier, Public Network was added > when plugin receives event about physical network creation. > - Some bug fixes in contrail plugin. > - Contrail plugin is enabled my added spring context xml file. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/16274/diff/ > > > Testing > ------- > > - Contrail plugin code is completely tested. > - VPC tests are verified. > > > File Attachments > ---------------- > > Contrail VPC Implementation > > https://reviews.apache.org/media/uploaded/files/2013/12/15/206339e2-7695-48b9-8549-f9090d5e24c7__juniper-contrail-vpc-implementation.patch > > > Thanks, > > Suresh Balineni > >
