----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16605/#review31226 -----------------------------------------------------------
Ship it! Committed in ef51def9fff3610b13f50be39c7610262d4a1c04. Kindly close the review request. - Devdeep Singh On Jan. 3, 2014, 11:42 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16605/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 11:42 a.m.) > > > Review request for cloudstack, Devdeep Singh and rajeshbabu chintaguntla. > > > Repository: cloudstack-git > > > Description > ------- > > this patch fixes the special characters not working in cnsole view for > hyperv. Added the keymap for special keys and modified modifeir keys handling > > > Diffs > ----- > > > services/console-proxy-rdp/rdpconsole/src/main/java/rdpclient/adapter/AwtRdpKeyboardAdapter.java > 36da0a3 > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyRdpClient.java > 6b317ff > > services/console-proxy/server/src/com/cloud/consoleproxy/rdp/KeysymToKeycode.java > 10282ad > > Diff: https://reviews.apache.org/r/16605/diff/ > > > Testing > ------- > > verified by typing special keys in console view of vm in hyperv > > > Thanks, > > Anshul Gangwar > >