----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16683/#review31341 -----------------------------------------------------------
Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan. 7, 2014, 12:14 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16683/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2014, 12:14 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5805 > https://issues.apache.org/jira/browse/CLOUDSTACK-5805 > > > Repository: cloudstack-git > > > Description > ------- > > Increased time out for VM to come up to running state because some test cases > failed with "failed to start VM even after 10 minutes". > > > Diffs > ----- > > test/integration/component/test_reset_ssh_keypair.py 7530335 > > Diff: https://reviews.apache.org/r/16683/diff/ > > > Testing > ------- > > Tested locally. > > Log: > > test_01_reset_keypair_normal_user > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for non admin non root ... ok > test_02_reset_keypair_domain_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin non root ... skipped > 'skip' > test_03_reset_keypair_root_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin root ... skipped > 'skip' > test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair) > Test Reset SSH keys for VM already having SSH key ... skipped 'skip' > test_02_reset_ssh_key_password_enabled_template > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... skipped > 'skip' > test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH key for VM having no SSH key ... skipped 'skip' > test_04_reset_key_passwd_enabled_no_key > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_05_reset_key_in_running_state > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM already having SSH key when VM is in running ... > skipped 'skip' > test_06_reset_key_passwd_enabled_vm_running > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... skipped > 'skip' > test_07_reset_keypair_invalid_params > (test_reset_ssh_keypair.TestResetSSHKeypair) > Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... skipped > 'skip' > > ---------------------------------------------------------------------- > Ran 10 tests in 1355.765s > > OK (skipped=8) > > > Thanks, > > Gaurav Aradhye > >