I mean to have the setting of the vars and the vars them selves be static , not the retrieving method.
On Thu, Jan 9, 2014 at 1:52 PM, Mandar Barve <mandar.ba...@sungard.com> wrote: > Daan, > I don't get the idea behind making the methods static. Making > getter/setters static will lead to instance vars losing their meaning and we > need each instance to let us know its sensitivity. I assume you are not > suggesting changing the abstract method into static. Can you please explain? > > Thanks, > Mandar > > > On Wed, Jan 8, 2014 at 8:24 PM, daan Hoogland <daan.hoogl...@gmail.com> > wrote: >> >> >> >> > On Dec. 23, 2013, 5:58 p.m., Nitin Mehta wrote: >> > > >> > > api/src/org/apache/cloudstack/api/BaseListTemplateOrIsoPermissionsCmd.java, >> > > line 53 >> > > >> > > <https://reviews.apache.org/r/16385/diff/1/?file=400860#file400860line53> >> >> > > >> > > You shouldn't have to override for every cmd. By default its false >> > > and the cmds having sensitive information can have methods returning >> > > true. >> > > Also they do not need to be set in execute. This is static information, >> > > doesn't change per command so why this needs to be set ? >> > >> > Mandar Barve wrote: >> > Nitin, >> > You are right. This was discussed in the earlier discussion >> > thread. You should really have to modify only commands that carry sensitive >> > information. The problem with that approach as stated earlier is API >> > developer can forget to declare command/response sensitivity by >> > implementing >> > a method that sets the flags, returns true etc. The wrapper abstract method >> > was introduced essentially to ensure new APIs as they get introduced will >> > give compiler error if this wrapper is not implemented enforcing the >> > developer to declare such sensitivity upfront. >> > Hope that addresses your concern. >> > >> > Thanks, >> > Mandar >> > >> > Nitin Mehta wrote: >> > Thanks Mandar. I see your point and was thinking on the same lines >> > as well. I appreciate your thinking for future API devs. But I have the >> > following concerns >> > 1. I probably think that this information should be static for the >> > Cmd class and doesnt have to be set on every execute invocation >> > 2. For few commands having sensitive information we are writing >> > boilerplate code in all the api's, this is not en elegant way of enforcing >> > every API developer to look into this. I would rather want this to be dealt >> > through an annotation (if it doesnt exist lets create one in the public >> > @interface APICommand and keep the default value to true that it contains >> > sensitive information) >> > >> > Mandar Barve wrote: >> > Nitin, >> > I see us going back to PROPOSAL discussion which is fine but >> > IMO its happening little late. >> > >> > I am new to this process of development in CloudStack and would >> > want to take this opportunity to understand how this thing works. As I >> > understood it I tried to: >> > - reproduce and understand the issue, come up with a solution, >> > - ran a PoC making sure the proposed solution will work, will scale >> > etc. >> > - Put down a proposal providing multiple solution approaches >> > discussing pros/cons and shared with the team inviting comments. >> > - Addressed all the concerns related to the proposal until I saw no >> > more concerns raised over this. >> > - went through an entire exercise of manually changing each command >> > file carefully going through API doc with the proposed change. >> > >> > I truly appreciate all the comments and also understand sometimes >> > important things may need to be addressed even if they are late. Is there >> > any norm in the community to close a "PROPOSAL/DISCUSS" phase? Are we >> > supposed to get "VOTE" on the proposed solution before moving to >> > implementation? This didn't look like the case for every discussion from my >> > reading of wiki. >> > >> > Now coming to your comments on the PROPOSAL. You are suggesting >> > making declarative changes (static)to API Commands e.g. to APICommand >> > annotation or a new annotation. Something like this can surely make the >> > change look more elegant in the sense the change itself will potentially be >> > limited to one/two lines per file (ensuring all annotations for all >> > commands >> > are changed to the new one) and won't need a call from execute. The >> > checking >> > code will need to load the annotation to check the flag status in the >> > annotation meaning a reflective code. Daan had earlier proposed using >> > reflection with string match but also had raised security concerns over >> > using reflection. Leaving that aside, to ensure every API does its job of >> > declaring sensitivity upfront we should really be able to enforce it at >> > compile time like mentioned before. I don't see a way to enforce annotation >> > implementation by all sub classes at compile time. IF such method doesn't >> > exist then we will be leaving use of this a >> nnotation to the mercy of the API developer who can forget to do so. In >> such case your default true values can come into play but then essentially >> losing the whole purpose where a command that is not sensitive will still >> need to go through a cleanString call. >> > >> > Assuming we apply this annotation to all known API commands to >> > date close to 437 files will need to change and that is truly a boiler >> > plate >> > change. If we rely on using default "false" e.g. and modify only sensitive >> > classes then also it can come to around 50 files or little more I believe >> > with a hole left open where newly added commands can go without annotation >> > with unintended results as mentioned above. >> > >> > In my solution the abstract method is addressing these issues >> > and yes is a one time boiler plate change but will scale fine. >> > >> > The question is do we want to bite this bullet? >> > >> > Thanks, >> > Mandar >> > >> >> Mandar, can yo0u make the methods static? >> >> Nitin: Are your concerns met with Mandar's explanation? >> >> >> - daan >> >> >> ----------------------------------------------------------- >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/16385/#review30828 >> ----------------------------------------------------------- >> >> >> On Dec. 23, 2013, 6:13 p.m., Mandar Barve wrote: >> > >> > ----------------------------------------------------------- >> >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/16385/ >> > ----------------------------------------------------------- >> > >> > (Updated Dec. 23, 2013, 6:13 p.m.) >> >> > >> > >> > Review request for cloudstack and daan Hoogland. >> > >> > >> > Bugs: CLOUDSTACK-4406 >> > https://issues.apache.org/jira/browse/CLOUDSTACK-4406 >> > >> > >> > Repository: cloudstack-git >> > >> > >> > Description >> > ------- >> >> > >> > JIRA 4406 expects removal of cleanString() call for performance >> > improvements. This is called when building audit trail for command >> > responses >> > and used for removing sensitive data (passwords, secret keys) from the log >> > buffer. All the API responses do not carry such sensitive information so >> > pattern matching done by cleanString against all API response strings can >> > be >> > costly. >> > >> > I propose following for a solution: >> > >> > * Modify BaseCmd class to add flags that will store cmd/response >> > sensitivity >> > * At init these flags will be set to false indicating no cmd req/resp >> > carries sensitive data >> > * any child api cmd class that will carry sensitive data in the req/resp >> > should set the respective flags >> > * before calling any logging function the flag should be checked and >> > cleanString should be called only for cmds with flags set >> > >> > Pro: This approach will scale well as new cmds get added and no >> > additional changes should be required. >> > Con: Big change upfront as it will touch all API cmd classes that carry >> > sensitive information along with BaseCmd class. >> > >> > NOTE: changes should be simple and straightforward though spread across >> > multiple classes. >> > >> > >> > Diffs >> > ----- >> > >> > api/src/com/cloud/api/commands/ListRecurringSnapshotScheduleCmd.java >> > d34c09c >> > api/src/org/apache/cloudstack/api/BaseCmd.java 0cfb950 >> > >> > api/src/org/apache/cloudstack/api/BaseListTemplateOrIsoPermissionsCmd.java >> > 48c1e02 >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java >> > c5a2d1a >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java >> > 7c1b206 >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java >> > 6fdbefe >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java >> > 59d6acd >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java >> > 93ec1be >> > >> > api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java >> > a8cf63f >> > >> > api/src/org/apache/cloudstack/api/command/admin/alert/GenerateAlertCmd.java >> > 620c5ed >> > >> > api/src/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterCmd.java >> > 6c4b81b >> > >> > api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounterCmd.java >> > 50477f5 >> > >> > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java >> > d0e7380 >> > >> > api/src/org/apache/cloudstack/api/command/admin/cluster/DeleteClusterCmd.java >> > e1bc585 >> > >> > api/src/org/apache/cloudstack/api/command/admin/cluster/ListClustersCmd.java >> > 8640f37 >> > >> > api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java >> > b13f81a >> > >> > api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java >> > 517807d >> > >> > api/src/org/apache/cloudstack/api/command/admin/config/ListDeploymentPlannersCmd.java >> > 1d9d2d9 >> > >> > api/src/org/apache/cloudstack/api/command/admin/config/ListHypervisorCapabilitiesCmd.java >> > 16adf66 >> > >> > api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java >> > 9bc9b3c >> > >> > api/src/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java >> > 5cb5f9c >> > >> > api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java >> > 4737555 >> > >> > api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java >> > b1075c1 >> > >> > api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainChildrenCmd.java >> > e1ba178 >> > >> > api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java >> > 5a3786c >> > >> > api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java >> > 8acfcd5 >> > api/src/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java >> > 363bcd6 >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java >> > 61f6f49 >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/CancelMaintenanceCmd.java >> > 46289ee >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/DeleteHostCmd.java >> > 5a4478e >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java >> > 0faf72c >> > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java >> > eda821b >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java >> > 23cfacf >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java >> > 1ce888b >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/ReleaseHostReservationCmd.java >> > b60feca >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java >> > d778b37 >> > >> > api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java >> > 69480b1 >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/ConfigureInternalLoadBalancerElementCmd.java >> > 51da760 >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/CreateInternalLoadBalancerElementCmd.java >> > a6ece72 >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/ListInternalLBVMsCmd.java >> > 0e01be1 >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/ListInternalLoadBalancerElementsCmd.java >> > a42a0b3 >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/StartInternalLBVMCmd.java >> > 56dcb4f >> > >> > api/src/org/apache/cloudstack/api/command/admin/internallb/StopInternalLBVMCmd.java >> > 9da4db0 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java >> > 7af9355 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkServiceProviderCmd.java >> > f190493 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java >> > 5614295 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/CreatePhysicalNetworkCmd.java >> > de4e5e5 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/CreateStorageNetworkIpRangeCmd.java >> > cfbbd36 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java >> > 51b4924 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkDeviceCmd.java >> > 96e4fa5 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkOfferingCmd.java >> > 3aa7d66 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkServiceProviderCmd.java >> > c4993c3 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DeletePhysicalNetworkCmd.java >> > 828683a >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/DeleteStorageNetworkIpRangeCmd.java >> > 42c9619 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListDedicatedGuestVlanRangesCmd.java >> > ca7c1f7 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java >> > de175d0 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkIsolationMethodsCmd.java >> > d30f7b8 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkServiceProvidersCmd.java >> > 5a1235b >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListPhysicalNetworksCmd.java >> > 3ac2faa >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListStorageNetworkIpRangeCmd.java >> > 89cba47 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ListSupportedNetworkServicesCmd.java >> > 342f9b0 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/ReleaseDedicatedGuestVlanRangeCmd.java >> > 43e1149 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java >> > 957450f >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkServiceProviderCmd.java >> > c530c53 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java >> > f808424 >> > >> > api/src/org/apache/cloudstack/api/command/admin/network/UpdateStorageNetworkIpRangeCmd.java >> > 9fd084a >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java >> > 1d959a0 >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java >> > 6f9693c >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/DeleteDiskOfferingCmd.java >> > 9845aa4 >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/DeleteServiceOfferingCmd.java >> > 0f81409 >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java >> > 6d45fb5 >> > >> > api/src/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java >> > fbc8845 >> > api/src/org/apache/cloudstack/api/command/admin/pod/CreatePodCmd.java >> > 835a3b9 >> > api/src/org/apache/cloudstack/api/command/admin/pod/DeletePodCmd.java >> > 584eed4 >> > api/src/org/apache/cloudstack/api/command/admin/pod/ListPodsByCmd.java >> > 75b5efd >> > api/src/org/apache/cloudstack/api/command/admin/pod/UpdatePodCmd.java >> > 7b8f6eb >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java >> > 9e7c035 >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/CreatePortableIpRangeCmd.java >> > e900f47 >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/DeletePortableIpRangeCmd.java >> > 5408eda >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java >> > 42a92e6 >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/RemoveRegionCmd.java >> > e912659 >> > >> > api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java >> > 527e142 >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java >> > b1177b9 >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/CleanVMReservationsCmd.java >> > edc3bcf >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java >> > 8ba2525 >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java >> > 397b00a >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java >> > 2b0f827 >> > >> > api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java >> > 68ef5ac >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java >> > 75b08b1 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/ConfigureVirtualRouterElementCmd.java >> > 2cfefda >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/CreateVirtualRouterElementCmd.java >> > bf5eb18 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/DestroyRouterCmd.java >> > 2ad312e >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java >> > d5f73fd >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/ListRoutersCmd.java >> > 9c91e0f >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/ListVirtualRouterElementsCmd.java >> > 6f17921 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/RebootRouterCmd.java >> > 15527d3 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/StartRouterCmd.java >> > 9196cd0 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/StopRouterCmd.java >> > ee2b9eb >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/UpgradeRouterCmd.java >> > 04a4e67 >> > >> > api/src/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java >> > 4947745 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreCmd.java >> > 5dcedff >> > api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java >> > e665b7d >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/CancelPrimaryStorageMaintenanceCmd.java >> > b1c5594 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java >> > 1480e75 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java >> > dfd0026 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/DeleteImageStoreCmd.java >> > 602da83 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/DeletePoolCmd.java >> > fb63daa >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/DeleteSecondaryStagingStoreCmd.java >> > caf937f >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java >> > 10813ca >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/ListImageStoresCmd.java >> > bf47084 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/ListS3sCmd.java >> > 362d69e >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/ListSecondaryStagingStoresCmd.java >> > 171f971 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/ListStoragePoolsCmd.java >> > 868b402 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/ListStorageProvidersCmd.java >> > bac6b7c >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/PreparePrimaryStorageForMaintenanceCmd.java >> > 9d11966 >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/PrepareSecondaryStorageForMigrationCmd.java >> > a57f2df >> > >> > api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java >> > 50be6ba >> > api/src/org/apache/cloudstack/api/command/admin/swift/AddSwiftCmd.java >> > 3b684f4 >> > >> > api/src/org/apache/cloudstack/api/command/admin/swift/ListSwiftsCmd.java >> > fcc8e46 >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/DestroySystemVmCmd.java >> > 07e111c >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/ListSystemVMsCmd.java >> > 9480497 >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/MigrateSystemVMCmd.java >> > 8199e68 >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/RebootSystemVmCmd.java >> > 1c38b05 >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java >> > fdb81ea >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/StartSystemVMCmd.java >> > 2e65928 >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/StopSystemVmCmd.java >> > 7709ebe >> > >> > api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java >> > a89abb8 >> > >> > api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java >> > 16761ba >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficMonitorCmd.java >> > 031fc8d >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java >> > e6e18cb >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/DeleteTrafficMonitorCmd.java >> > debaf00 >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/DeleteTrafficTypeCmd.java >> > 111e177 >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/GenerateUsageRecordsCmd.java >> > 4fc36ab >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java >> > a8bd1e5 >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficMonitorsCmd.java >> > 3592539 >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypeImplementorsCmd.java >> > 159608e >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java >> > 47ba781 >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/ListUsageTypesCmd.java >> > b5e445b >> > >> > api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java >> > 2ad470e >> > >> > api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java >> > 03512db >> > >> > api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java >> > 6ba382a >> > >> > api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java >> > 599328d >> > >> > api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java >> > 8d37eda >> > api/src/org/apache/cloudstack/api/command/admin/user/GetUserCmd.java >> > 592b828 >> > api/src/org/apache/cloudstack/api/command/admin/user/ListUsersCmd.java >> > 41d6acd >> > api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java >> > 9533004 >> > api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java >> > facdc87 >> > >> > api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java >> > de6e550 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java >> > dbaac6e >> > >> > api/src/org/apache/cloudstack/api/command/admin/vlan/DedicatePublicIpRangeCmd.java >> > 2650482 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vlan/DeleteVlanIpRangeCmd.java >> > 8d29130 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java >> > 9d6eae6 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vlan/ReleasePublicIpRangeCmd.java >> > 2c160be >> > api/src/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java >> > c9b5c9f >> > api/src/org/apache/cloudstack/api/command/admin/vm/ExpungeVMCmd.java >> > 7b16686 >> > api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java >> > 3706d50 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java >> > 90918bf >> > api/src/org/apache/cloudstack/api/command/admin/vm/RecoverVMCmd.java >> > abf5168 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java >> > c3201f1 >> > >> > api/src/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java >> > 96d5c6a >> > >> > api/src/org/apache/cloudstack/api/command/admin/vpc/DeletePrivateGatewayCmd.java >> > a5bb00c >> > >> > api/src/org/apache/cloudstack/api/command/admin/vpc/DeleteVPCOfferingCmd.java >> > 7abaa7d >> > >> > api/src/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java >> > 3526b4b >> > >> > api/src/org/apache/cloudstack/api/command/admin/zone/CreateZoneCmd.java >> > 0846102 >> > >> > api/src/org/apache/cloudstack/api/command/admin/zone/DeleteZoneCmd.java >> > 3e74625 >> > >> > api/src/org/apache/cloudstack/api/command/admin/zone/MarkDefaultZoneForAccountCmd.java >> > fe2bc6a >> > >> > api/src/org/apache/cloudstack/api/command/admin/zone/UpdateZoneCmd.java >> > f0074c5 >> > >> > api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProjectCmd.java >> > 36df579 >> > >> > api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFromProjectCmd.java >> > f6aa36c >> > >> > api/src/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java >> > bc93d21 >> > >> > api/src/org/apache/cloudstack/api/command/user/account/ListProjectAccountsCmd.java >> > aa60016 >> > >> > api/src/org/apache/cloudstack/api/command/user/address/AssociateIPAddrCmd.java >> > 4df658b >> > >> > api/src/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java >> > e3669be >> > >> > api/src/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java >> > a5c54ad >> > >> > api/src/org/apache/cloudstack/api/command/user/affinitygroup/CreateAffinityGroupCmd.java >> > a2542a8 >> > >> > api/src/org/apache/cloudstack/api/command/user/affinitygroup/DeleteAffinityGroupCmd.java >> > a6cf1bb >> > >> > api/src/org/apache/cloudstack/api/command/user/affinitygroup/ListAffinityGroupTypesCmd.java >> > 87de7f7 >> > >> > api/src/org/apache/cloudstack/api/command/user/affinitygroup/ListAffinityGroupsCmd.java >> > 367dec9 >> > >> > api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java >> > 7bb1c5b >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScalePolicyCmd.java >> > ce6dc68 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmGroupCmd.java >> > 5547974 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java >> > bee1b22 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/CreateConditionCmd.java >> > 914848a >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScalePolicyCmd.java >> > 1aedf57 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScaleVmGroupCmd.java >> > a7823b4 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScaleVmProfileCmd.java >> > 3d6d030 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteConditionCmd.java >> > 0cc2319 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/DisableAutoScaleVmGroupCmd.java >> > 2bd6f87 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/EnableAutoScaleVmGroupCmd.java >> > dc89f2b >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScalePoliciesCmd.java >> > 84ed30a >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmGroupsCmd.java >> > 4eda7a8 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java >> > 651f987 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/ListConditionsCmd.java >> > 015f3ed >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/ListCountersCmd.java >> > f503b2b >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScalePolicyCmd.java >> > 91adeb1 >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScaleVmGroupCmd.java >> > dbbd85f >> > >> > api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScaleVmProfileCmd.java >> > f3361d8 >> > >> > api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java >> > 5c00814 >> > >> > api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java >> > e51f850 >> > >> > api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java >> > d00b58d >> > >> > api/src/org/apache/cloudstack/api/command/user/event/ListEventTypesCmd.java >> > 7a58d4c >> > >> > api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java >> > 0e45e4e >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java >> > 778a18b >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java >> > 44aa26f >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java >> > 89dc077 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java >> > 8e7b679 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java >> > c3029b8 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/DeletePortForwardingRuleCmd.java >> > c493dd0 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java >> > 44d26e4 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/ListPortForwardingRulesCmd.java >> > bd8a7a1 >> > >> > api/src/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java >> > d7e380f >> > >> > api/src/org/apache/cloudstack/api/command/user/guest/ListGuestOsCategoriesCmd.java >> > 604f1ed >> > >> > api/src/org/apache/cloudstack/api/command/user/guest/ListGuestOsCmd.java >> > 287fb1e >> > api/src/org/apache/cloudstack/api/command/user/iso/AttachIsoCmd.java >> > d38c816 >> > api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java >> > 91ad5f1 >> > api/src/org/apache/cloudstack/api/command/user/iso/DetachIsoCmd.java >> > e40195b >> > api/src/org/apache/cloudstack/api/command/user/iso/ExtractIsoCmd.java >> > 2fb215a >> > api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java >> > 3e66e52 >> > api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java >> > 29e3d67 >> > api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoCmd.java >> > 6a471c9 >> > >> > api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoPermissionsCmd.java >> > 8267b5c >> > >> > api/src/org/apache/cloudstack/api/command/user/job/ListAsyncJobsCmd.java >> > 9d45d50 >> > >> > api/src/org/apache/cloudstack/api/command/user/job/QueryAsyncJobResultCmd.java >> > 1f9f5db >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java >> > 4ea4a58 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java >> > bcf6200 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateApplicationLoadBalancerCmd.java >> > 0b8d377 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLBHealthCheckPolicyCmd.java >> > 5ff7239 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLBStickinessPolicyCmd.java >> > 159fcf5 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java >> > 764e379 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteApplicationLoadBalancerCmd.java >> > 0b53d53 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLBHealthCheckPolicyCmd.java >> > d625ed5 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLBStickinessPolicyCmd.java >> > c4f72d9 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLoadBalancerRuleCmd.java >> > 1dc3cd1 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java >> > d5683b0 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListApplicationLoadBalancersCmd.java >> > 05572c8 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLBHealthCheckPoliciesCmd.java >> > 8aa286f >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLBStickinessPoliciesCmd.java >> > ade4878 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java >> > 2a39e1a >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRulesCmd.java >> > 663f991 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java >> > 7f8118a >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java >> > e92d208 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveFromLoadBalancerRuleCmd.java >> > 5027ad3 >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/UpdateLoadBalancerRuleCmd.java >> > d68167d >> > >> > api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java >> > 00bd013 >> > >> > api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java >> > 0917d52 >> > >> > api/src/org/apache/cloudstack/api/command/user/nat/DeleteIpForwardingRuleCmd.java >> > 66a9f8a >> > >> > api/src/org/apache/cloudstack/api/command/user/nat/DisableStaticNatCmd.java >> > 351d3ae >> > >> > api/src/org/apache/cloudstack/api/command/user/nat/EnableStaticNatCmd.java >> > 832cbc2 >> > >> > api/src/org/apache/cloudstack/api/command/user/nat/ListIpForwardingRulesCmd.java >> > dca1c23 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java >> > 9934a4f >> > >> > api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkACLListCmd.java >> > cd0eb32 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java >> > c1e56ebd >> > >> > api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkACLCmd.java >> > 7413ea5 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkACLListCmd.java >> > 632d710 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkCmd.java >> > a48e01b >> > >> > api/src/org/apache/cloudstack/api/command/user/network/ListNetworkACLListsCmd.java >> > 2e50bb8 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/ListNetworkACLsCmd.java >> > 7f8aef4 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/ListNetworkOfferingsCmd.java >> > 552a64a >> > >> > api/src/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java >> > 72c52df >> > >> > api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java >> > de1f163 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/RestartNetworkCmd.java >> > cd508ff >> > >> > api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLItemCmd.java >> > 1e559c2 >> > >> > api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java >> > 2091102 >> > >> > api/src/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java >> > 954b64e >> > >> > api/src/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java >> > 08c69e8 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/ActivateProjectCmd.java >> > 66c64a6 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/CreateProjectCmd.java >> > dcb83a8 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java >> > 88205e8 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/DeleteProjectInvitationCmd.java >> > 9d4d838 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/ListProjectInvitationsCmd.java >> > 0e9e7ae >> > >> > api/src/org/apache/cloudstack/api/command/user/project/ListProjectsCmd.java >> > 2cf6106 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/SuspendProjectCmd.java >> > c2a1885 >> > >> > api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectCmd.java >> > 78903bf >> > >> > api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInvitationCmd.java >> > dda7b54 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ListRegionsCmd.java >> > c369b9c >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/AssignToGlobalLoadBalancerRuleCmd.java >> > 1fe73b5 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/CreateGlobalLoadBalancerRuleCmd.java >> > 550d817 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/DeleteGlobalLoadBalancerRuleCmd.java >> > 2e96965 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/ListGlobalLoadBalancerRuleCmd.java >> > f37aba2 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/RemoveFromGlobalLoadBalancerRuleCmd.java >> > b30f4d8 >> > >> > api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/UpdateGlobalLoadBalancerRuleCmd.java >> > e8c5326 >> > >> > api/src/org/apache/cloudstack/api/command/user/resource/GetCloudIdentifierCmd.java >> > ccaca2d >> > >> > api/src/org/apache/cloudstack/api/command/user/resource/ListHypervisorsCmd.java >> > 5e546f4 >> > >> > api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java >> > ba3cfc8 >> > >> > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java >> > bd4f995 >> > >> > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java >> > c33a9e7 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupEgressCmd.java >> > 6a054a4 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupIngressCmd.java >> > be91959 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/CreateSecurityGroupCmd.java >> > 3b16821 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/DeleteSecurityGroupCmd.java >> > 0bcc144 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/ListSecurityGroupsCmd.java >> > ae745b3 >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupEgressCmd.java >> > 006aa7d >> > >> > api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupIngressCmd.java >> > 0858578 >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java >> > a0f307b >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java >> > 5ecbaaa >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotCmd.java >> > 35caaff >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotPoliciesCmd.java >> > bcccf8b >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotPoliciesCmd.java >> > 7c2899f >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java >> > e4d566a >> > >> > api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java >> > f11fa3f >> > >> > api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java >> > 1fc9d13 >> > >> > api/src/org/apache/cloudstack/api/command/user/ssh/DeleteSSHKeyPairCmd.java >> > a638eb9 >> > >> > api/src/org/apache/cloudstack/api/command/user/ssh/ListSSHKeyPairsCmd.java >> > 52fca5f >> > >> > api/src/org/apache/cloudstack/api/command/user/ssh/RegisterSSHKeyPairCmd.java >> > 8ed5cbd >> > api/src/org/apache/cloudstack/api/command/user/tag/CreateTagsCmd.java >> > ee0add4 >> > api/src/org/apache/cloudstack/api/command/user/tag/DeleteTagsCmd.java >> > 3ee7c06 >> > api/src/org/apache/cloudstack/api/command/user/tag/ListTagsCmd.java >> > 893f6df >> > >> > api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java >> > 78bfc18 >> > >> > api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java >> > 0030a7e >> > >> > api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java >> > 890af70 >> > >> > api/src/org/apache/cloudstack/api/command/user/template/ExtractTemplateCmd.java >> > 082f46a >> > >> > api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java >> > 7e347f3 >> > >> > api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java >> > 48ed6ea >> > >> > api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java >> > f80a4ee >> > >> > api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplatePermissionsCmd.java >> > 96d1f55 >> > api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java >> > 09a9122 >> > api/src/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java >> > 43efe16 >> > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java >> > 2472a42 >> > api/src/org/apache/cloudstack/api/command/user/vm/DestroyVMCmd.java >> > 3c63e8d >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/GetVMPasswordCmd.java >> > d0503d1 >> > api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java >> > 8cb9575 >> > api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java >> > 3f161c1 >> > api/src/org/apache/cloudstack/api/command/user/vm/RebootVMCmd.java >> > 7ac9138 >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java >> > 9b86577 >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java >> > 92becb7 >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/ResetVMPasswordCmd.java >> > df34120 >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java >> > 7436e3d >> > api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java >> > b69b364 >> > api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java >> > e122834 >> > api/src/org/apache/cloudstack/api/command/user/vm/StartVMCmd.java >> > 4239a64 >> > api/src/org/apache/cloudstack/api/command/user/vm/StopVMCmd.java >> > 17f12f9 >> > >> > api/src/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java >> > f699cce >> > api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java >> > e0ca787 >> > api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java >> > 033717d >> > >> > api/src/org/apache/cloudstack/api/command/user/vmgroup/CreateVMGroupCmd.java >> > 937fca3 >> > >> > api/src/org/apache/cloudstack/api/command/user/vmgroup/DeleteVMGroupCmd.java >> > fbfb85a >> > >> > api/src/org/apache/cloudstack/api/command/user/vmgroup/ListVMGroupsCmd.java >> > fda3e88 >> > >> > api/src/org/apache/cloudstack/api/command/user/vmgroup/UpdateVMGroupCmd.java >> > 1930bd8 >> > >> > api/src/org/apache/cloudstack/api/command/user/vmsnapshot/CreateVMSnapshotCmd.java >> > de921f6 >> > >> > api/src/org/apache/cloudstack/api/command/user/vmsnapshot/DeleteVMSnapshotCmd.java >> > d29ff05 >> > >> > api/src/org/apache/cloudstack/api/command/user/vmsnapshot/ListVMSnapshotCmd.java >> > 84b552c >> > >> > api/src/org/apache/cloudstack/api/command/user/vmsnapshot/RevertToVMSnapshotCmd.java >> > cec2154 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/AddResourceDetailCmd.java >> > 69d1ca7 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/AttachVolumeCmd.java >> > cd1e1ed >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java >> > c6457c6 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/DeleteVolumeCmd.java >> > 550adb9 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/DetachVolumeCmd.java >> > 70283ff >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/ExtractVolumeCmd.java >> > d73143a >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/ListResourceDetailsCmd.java >> > aed0ae0 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java >> > 4ebe3bf >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java >> > fa6ac69 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/RemoveResourceDetailCmd.java >> > c4c7554 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java >> > 0cc8039 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java >> > b57f2b4 >> > >> > api/src/org/apache/cloudstack/api/command/user/volume/UploadVolumeCmd.java >> > 991cfc1 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpc/CreateStaticRouteCmd.java >> > f2d2bce >> > api/src/org/apache/cloudstack/api/command/user/vpc/CreateVPCCmd.java >> > d4c52b8 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpc/DeleteStaticRouteCmd.java >> > 937341e >> > api/src/org/apache/cloudstack/api/command/user/vpc/DeleteVPCCmd.java >> > 14f21ba >> > >> > api/src/org/apache/cloudstack/api/command/user/vpc/ListPrivateGatewaysCmd.java >> > 7870673 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpc/ListStaticRoutesCmd.java >> > 931431b >> > >> > api/src/org/apache/cloudstack/api/command/user/vpc/ListVPCOfferingsCmd.java >> > e3d0bc6 >> > api/src/org/apache/cloudstack/api/command/user/vpc/ListVPCsCmd.java >> > 45ab863 >> > api/src/org/apache/cloudstack/api/command/user/vpc/RestartVPCCmd.java >> > eb048ce >> > api/src/org/apache/cloudstack/api/command/user/vpc/UpdateVPCCmd.java >> > 5732c65 >> > api/src/org/apache/cloudstack/api/command/user/vpn/AddVpnUserCmd.java >> > 7c58117 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/CreateRemoteAccessVpnCmd.java >> > 9277c49 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnConnectionCmd.java >> > 2c2bf55 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnCustomerGatewayCmd.java >> > 821a4b0 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnGatewayCmd.java >> > 8955c8e >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteRemoteAccessVpnCmd.java >> > 41a8f1e >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnConnectionCmd.java >> > c86cc59 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnCustomerGatewayCmd.java >> > 4c777d7 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnGatewayCmd.java >> > 85f4004 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ListRemoteAccessVpnsCmd.java >> > 01e6d37 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnConnectionsCmd.java >> > 8de6059 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnCustomerGatewaysCmd.java >> > 5cd4bfb >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnGatewaysCmd.java >> > 75a5e81 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnUsersCmd.java >> > 5136633 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/RemoveVpnUserCmd.java >> > 4eeef67 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/ResetVpnConnectionCmd.java >> > efe6db8 >> > >> > api/src/org/apache/cloudstack/api/command/user/vpn/UpdateVpnCustomerGatewayCmd.java >> > 5694a74 >> > >> > api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java >> > 471e6d6 >> > >> > plugins/api/discovery/src/org/apache/cloudstack/api/command/user/discovery/ListApisCmd.java >> > 206d793 >> > >> > plugins/api/rate-limit/src/org/apache/cloudstack/api/command/admin/ratelimit/ResetApiLimitCmd.java >> > 9e415e6 >> > >> > plugins/api/rate-limit/src/org/apache/cloudstack/api/command/user/ratelimit/GetApiLimitCmd.java >> > 2428895 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateClusterCmd.java >> > 4f8cd8c >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateHostCmd.java >> > d3cce5a >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicatePodCmd.java >> > e823fd5 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateZoneCmd.java >> > 0e427aa >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedClustersCmd.java >> > a2022a5 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedHostsCmd.java >> > d3b326d >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedPodsCmd.java >> > d7cd4c2 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedZonesCmd.java >> > 07b8b19 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedClusterCmd.java >> > e065da2 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedHostCmd.java >> > 41e668c >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedPodCmd.java >> > 47ea475 >> > >> > plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedZoneCmd.java >> > 69185d6 >> > >> > plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalDhcpCmd.java >> > 529f988 >> > >> > plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalPxeCmd.java >> > 19854a9 >> > >> > plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/ListBaremetalDhcpCmd.java >> > 7d0aba3 >> > >> > plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/ListBaremetalPxeServersCmd.java >> > 437fa3f >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/AddUcsManagerCmd.java >> > 17cd3ab >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/AssociateUcsProfileToBladeCmd.java >> > caea0be >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/DeleteUcsManagerCmd.java >> > 566ee30 >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsBladeCmd.java >> > 41c7cc1 >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsManagerCmd.java >> > 767682f >> > >> > plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsProfileCmd.java >> > cc49cef >> > >> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java >> > a30059d >> > >> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java >> > 4af45b2 >> > >> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java >> > 6e4ee75 >> > >> > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java >> > 50457d8 >> > >> > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java >> > 7842d37 >> > >> > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/DeleteNiciraNvpDeviceCmd.java >> > 374b0fe >> > >> > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDeviceNetworksCmd.java >> > 6d2dc05 >> > >> > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDevicesCmd.java >> > 78b2ad8 >> > >> > plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java >> > 7aba9c2 >> > >> > plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java >> > 80f02ad >> > >> > plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java >> > 4f147eb >> > >> > plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java >> > d1b7425 >> > >> > plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java >> > ad4be72 >> > >> > plugins/network-elements/stratosphere-ssp/src/org/apache/cloudstack/api/commands/AddSspCmd.java >> > 085f873 >> > >> > plugins/network-elements/stratosphere-ssp/src/org/apache/cloudstack/api/commands/DeleteSspCmd.java >> > e23f642 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java >> > db6d7dd >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java >> > 535a545 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java >> > 5686374 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java >> > 100ffe6 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java >> > b45bce5 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java >> > 89cec65 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java >> > b50970f >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListUsersCmd.java >> > 5c65ac4 >> > >> > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java >> > e2b050d >> > server/src/com/cloud/api/ApiServer.java 03361a4 >> > server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 >> > >> > Diff: https://reviews.apache.org/r/16385/diff/ >> > >> > >> > Testing >> > ------- >> >> > >> > Using CloudMonkey following commands have been tested to make sure >> > secret key/password is stripped from the response >> > list users >> > list accounts >> > list virtualmachines >> > create user >> > update user >> > create sshkeypair >> > >> > >> > Thanks, >> > >> > Mandar Barve >> > >> > >> >
